Skip to main content
Log In | Register

TR Memescape


Topic: Zombie forum is a 404 / Current forum upgrade discussion (Read 640 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.
  • 2,374

  • 858

Re: Zombie forum is a 404
Reply #25
Interesting.  A forum I had on ignore isn't on ignore anymore.

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #26
Sorry, I was ignoring this tab and scouting around for other stuff. Will take a look if you like, but if there are no error warnings it should be good to go.
Truth is out of style

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #27
So yeah, I looked. Seems ok. :parrot:
Truth is out of style

  • 2,374

  • 858

Re: Zombie forum is a 404
Reply #28
alrighty.  Might be a bumpy ride in a couple.

  • 2,374

  • 858

Re: Zombie forum is a 404
Reply #29
Ok, done.

Now what?

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #30
Now we do this: :stopper:
Truth is out of style

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #31
Ok seriously: this is usually how difficult it is to upgrade SMF or Elk. Only takes a few clicks. No worries.

You can delete the packages for 1.08 and 1.09 if you want to. It's highly unlikely you'll ever want to uninstall them. I usually just leave the latest one and delete earlier patch packages.
Truth is out of style

  • 2,374

  • 858

Re: Zombie forum is a 404
Reply #32
I'll delete 1.08 next week sometime.

  • 2,374

  • 858

Re: Zombie forum is a 404
Reply #33
The twitter embedder throws an error in the preinstall check - "Modification parse error"

http://www.elkarte.net/community/index.php?topic=2937.msg28673#msg28673

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #34
Looks like a fuckup. The package doesn't even contain a file of that name, so no wonder it can't extract it.

Also, the only js file the package does contain (twitter_embed.jquery.js) is a jQuery plug-in for lazy loading images.

Go grumble at Ema. :grin:
Truth is out of style

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #35
That was exceptionally diplomatic grumbling.
Truth is out of style

  • MSG
  • Needs a Life
  • 677

  • 186

Re: Zombie forum is a 404
Reply #36
when do we get our twitter embedding add-on?
braying among the ruins

  • F X
  • Needs a Life
  • The one and only
  • 1,390

  • 31

Re: Zombie forum is a 404
Reply #37
All that effort for  a zombie forum?  You people are dedicated.

"If you pick up a starving dog and make him prosperous he will not bite you. This is the principal difference between a dog and man."
― Mark Twain 🔭

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #38
when do we get our twitter embedding add-on?
As soon as you code it. :p
Truth is out of style

  • 2,374

  • 858

Re: Zombie forum is a 404
Reply #39
Right now, I'm waiting for a reply to the thread by the person who created and uploaded the broken twitter embed add-on.

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #40
I suspect what happened is he just threw in the wrong js file by mistake.
Truth is out of style

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #41
Got the updated package from Spuds. Deleted the old bodgey one, uploaded the new one, and ran the pre-installation check. Seems legit. :parrot:

ETA: Works on local. Jesus. I must be mental. I have a bloody Elk installation on local now.
  • Last Edit: March 07, 2017, 09:10:10 PM by osmanthus
Truth is out of style

  • 2,374

  • 858

Re: Zombie forum is a 404
Reply #42

  • 2,374

  • 858

Re: Zombie forum is a 404
Reply #43
sweeeeeeeeet

  • 2,374

  • 858

Re: Zombie forum is a 404
Reply #44
I can't get over how happy this makes me.

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404
Reply #45
Just go read some Trump news. That'll fix you.
Truth is out of style

  • SkepticTank
  • Global Moderator
  • Calmer than you are
  • 2,932

  • 487

Re: Zombie forum is a 404
Reply #46
I can't get over how happy this makes me.
It's nice, but I still want my tags.

  • SkepticTank
  • Global Moderator
  • Calmer than you are
  • 2,932

  • 487

Re: Zombie forum is a 404 / Current forum upgrade discussion
Reply #47
All that effort for  a zombie forum?  You people are dedicated.



haha, I changed the thread title to more accurately cover the discussion.

(it was easier than splitting).

  • osmanthus
  • Administrator
  • Fingerer of piglets
  • 4,410

  • 920

Re: Zombie forum is a 404 / Current forum upgrade discussion
Reply #48
Oi Raven. There's a setting for the embedding of twits javascript which loads the buggers before you get to them, and after testing it on local I think it's much less annoying than the default behaviour.

The "Setting Threshold" section on this page describes it: http://www.appelsiini.net/projects/lazyload

Code change for the Elk file (sauces/subs/TwitterEmbedder.integrate.php) is:

Code: (Find) [Select]
		if (self::$load_js === true)
{
loadJavascriptFile('twitter_embed.jquery.js', array('defer' => true));
addInlineJavascript('
$(document).ready(function() {
$(".twitter_embed").lazyload();
});', true);
self::$load_js = false;
}
Code: (Replace) [Select]
		if (self::$load_js === true)
{
loadJavascriptFile('twitter_embed.jquery.js', array('defer' => true));
addInlineJavascript('
$(document).ready(function() {
$(".twitter_embed").lazyload({
threshold : 800
});
});', true);
self::$load_js = false;
}
That loads up the twittery 800 px before you get to it, which is enough to have it sitting there happily by the time you want it, without making all the twits on the entire page load all at once.

It's not a perfect solution, because if you go straight to a post infested with twits it will still do the jumpy in yer face loading shiz, but it'll make a lot of them far less annoying.
 
Truth is out of style

  • 2,374

  • 858

Re: Zombie forum is a 404 / Current forum upgrade discussion
Reply #49
Sounds good. 

Do you want to make the change?  I'm on my tablet or asleep for the next six hours or so.